RFC: move patches/javafiles.patch to patches/ecj/

Omair Majid omajid at redhat.com
Fri May 13 09:14:11 PDT 2011


On 05/12/2011 08:32 PM, Dr Andrew John Hughes wrote:
> On 16:42 Thu 12 May     , Omair Majid wrote:
>> Hi,
>>
>> I have been looking at the patches/javafiles.patch file. It seems like
>> it adds extra classes to the file list so those classes can be added to
>> rt.jar. Surprisingly, I can build plain OpenJDK6 using IcedTea6 and it
>> contains the necessary classes.
>>
>> Sounds to me like this patch should be a bootstrap patch. The attached
>> patch moves it. I did icedtea6 builds both with and without bootstrap
>> and non of the classes mentioned in patches/javafiles.patch were missing.
>>
>> Any thoughts?
>>
>> ChangeLog:
>> 2011-05-12  Omair Majid<omajid at redhat.com>
>>
>>     * Makefile.am
>>     (ICEDTEA_PATCHES): Move javafiles.patch to ...
>>     (ICEDTEA_ECJ_PATCHES): Add new patch.
>>     * patches/javafiles.patch: Move to ...
>>     * patches/ecj/javafiles.patch: New file.
>>
>> Cheers,
>> Omair
>
> Have you tried just removing it altogether?  Can we still bootstrap?

Removing it completely was the first thing I attempted. But it looks 
like this patch is required for bootstrap: rt.jar in the bootstrap jdk 
does not contain the classes listed in the patch. Even java -version fails.

Cheers,
Omair



More information about the distro-pkg-dev mailing list