Reviewer needed - fix for JTreg tool in IcedTea7

[Dr Andrew John Hughes]

On 14:23 Mon 16 May     , Pavel Tisnovsky wrote:
> Hi all,
> 
> I'd like to push fix for JTreg tool into IcedTea7. This fix enables
> "process" flag for "compile" tag so some langtools tests does not end
> with "error" status, but are properly executed. Here you can see
> differences in langtools test results between unpatched IcedTea7 and
> patched one:
> 
> --- /jck/icedtea/test/check-langtools.log       2011-05-16
> 14:03:10.000000000 +0200
> +++ check-langtools.log 2011-05-16 13:12:35.000000000 +0200
> @@ -1248,15 +1248,15 @@
>  Passed: tools/javac/processing/6413690/T6413690.java
>  Passed: tools/javac/processing/6414633/T6414633.java
>  Passed: tools/javac/processing/6430209/T6430209.java
> -Error:  tools/javac/processing/6499119/ClassProcessor.java
> +FAILED: tools/javac/processing/6499119/ClassProcessor.java
>  Passed: tools/javac/processing/6511613/clss41701.java
>  Passed: tools/javac/processing/6512707/T6512707.java
>  Passed: tools/javac/processing/6634138/T6634138.java
>  Passed: tools/javac/processing/6994946/SemanticErrorTest.java
>  Passed: tools/javac/processing/6994946/SyntaxErrorTest.java
>  Passed: tools/javac/processing/completion/TestCompletions.java
> -Error:  tools/javac/processing/environment/round/TestContext.java
> -Error:
> tools/javac/processing/environment/round/TestElementsAnnotatedWith.java
> +Passed: tools/javac/processing/environment/round/TestContext.java
> +Passed:
> tools/javac/processing/environment/round/TestElementsAnnotatedWith.java
>  Passed: tools/javac/processing/environment/TestSourceVersion.java
>  Passed: tools/javac/processing/errors/TestParseErrors/TestParseErrors.java
>  Passed: tools/javac/processing/errors/TestErrorCount.java
> @@ -1267,10 +1267,10 @@
>  Passed: tools/javac/processing/filer/TestFilerConstraints.java
>  Passed: tools/javac/processing/filer/TestGetResource.java
>  Passed: tools/javac/processing/filer/TestGetResource2.java
> -Error:  tools/javac/processing/filer/TestInvalidRelativeNames.java
> +Passed: tools/javac/processing/filer/TestInvalidRelativeNames.java
>  Passed: tools/javac/processing/filer/TestLastRound.java
>  Passed: tools/javac/processing/filer/TestPackageInfo.java
> -Error:  tools/javac/processing/filer/TestValidRelativeNames.java
> +Passed: tools/javac/processing/filer/TestValidRelativeNames.java
>  Passed: tools/javac/processing/messager/6362067/T6362067.java
>  Passed: tools/javac/processing/messager/MessagerBasics.java
>  Passed: tools/javac/processing/model/6194785/T6194785.java
> @@ -1871,6 +1871,6 @@
>  Passed: tools/javap/T6879371.java
>  Passed: tools/javap/T6980017.java
>  Passed: tools/javap/T7004698.java
> -Test results: passed: 1,864; failed: 3; error: 5
> -Report written to /jck/icedtea/test/langtools/JTreport/html/report.html
> -Results written to /jck/icedtea/test/langtools/JTwork
> +Test results: passed: 1,868; failed: 4
> +Report written to /jck/1/icedtea/test/langtools/JTreport/html/report.html
> +Results written to /jck/1/icedtea/test/langtools/JTwork
> 
> 
> 
> hg diff generated against recent IcedTea7 version is stored in an
> attachment.
> 
> Here is ChangeLog entry:
> 
> 2011-05-16  Pavel Tisnovsky  <ptisnovs at redhat.com>
> 
>         * test/jtreg/README:
>         Updated.
>         * test/jtreg/com/sun/javatest/regtest/Path.java:
>         Added.
>         * test/jtreg/com/sun/javatest/regtest/Action.java:
>         * test/jtreg/com/sun/javatest/regtest/CompileAction.java:
>         *
> test/jtreg/com/sun/javatest/regtest/RegressionSecurityManager.java:
>         Corrected JTreg harness - this tool now accepts "process" flag for
>         "compile" tag.
> 
> Can anybody please review this change?
> 

Is this the same change that went into IcedTea6?  If so, ok.

I think we should consider separating out our jtreg support long term, so we
don't have to keep both in sync, but I'm not sure how feasible this is.

> Thank you in advance,
> Pavel

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37