Reviewer needed - fix for regression test test/sun/net/www/protocol/file/DirPermissionDenied in IcedTea7

[Dr Andrew John Hughes]

On 11:57 Fri 13 May     , Pavel Tisnovsky wrote:
> Dr Andrew John Hughes wrote:
> > On 17:46 Thu 12 May     , Pavel Tisnovsky wrote:
> > 
> > As mentioned in http://icedtea.classpath.org/wiki/CommitPolicy IcedTea7
> > patches are applied to the IcedTea forest, not to IcedTea7 itself.  For 2.0, all
> > patches will be removed from IcedTea7. See:
> > 
> > http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=712
> > 
> > Also, this patch is wrong anyway as it adds the patch as a bootstrapping patch.
> 
> Hi Andrew,
> 
> if I understand correctly, I'm able to directly change files in
> jdk|hotspot|...etc...etc...| repo in IcedTea7-forest right?
> 

Yes, on the IcedTea server.

> I've created hg diff against IcedTea7-forest which is stored in an
> attachment, but I'm not sure when to store Changelog entry - or are
> commit messages enough to keep track of changes?
> 

Yes, there's no ChangeLog in the forest.

You'll need to make a change to IcedTea7 itself as well to bump the
Mercurial revisions and checksums.  This will include a ChangeLog where
you can detail the actual change.  See IcedTea7's ChangeLog for some
examples from me.

> Cheers,
> Pavel

> diff -r cf7c64f276c6 test/sun/net/www/protocol/file/DirPermissionDenied.sh
> --- a/test/sun/net/www/protocol/file/DirPermissionDenied.sh	Wed May 11 11:08:03 2011 -0400
> +++ b/test/sun/net/www/protocol/file/DirPermissionDenied.sh	Fri May 13 11:44:06 2011 +0200
> @@ -37,5 +37,6 @@
>  
>  $TESTJAVA/bin/java -classpath $TESTCLASSES DirPermissionDenied ${TESTDIR}
>  result=$?
> +chmod u+r ${TESTDIR}
>  rm -rf ${TESTDIR}
>  exit $result


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37