[icedtea-web] RFC: Request to back out 0256de6a4bf6

Deepak Bhole dbhole at redhat.com
Mon May 16 10:55:44 PDT 2011


Hi,

http://icedtea.classpath.org/hg/release/icedtea-web-1.1/rev/0256de6a4bf6
makes it so that the VM shuts down after the last applet is closed.

The patch was committed with the known possibility that there could be a
race condition whereby one applet was initializing while the last one
closed. The probability of that was deemed to be low enough to not
matter.

However I think that assessment was incorrect on my part. I have come
across pages where one applet tries to launch a page that loads another.
In such case of programmatic switching, it is easier to end up with a
case where the VM shuts down when it shouldn't.

I would therefore like to back this patch out of 1.1.

The proper fix is to do shutdown from C++ side, which can then also
bring the VM back up if another applet is loaded. I have a patch do
this, but it will need some more testing and it shouldn't go in 1.1. I
will apply it to head after I am done testing it.

Okay to back out and replace with just commenting out tg.stop()?

Doing so may leak resources due to bad applets, but that is not really
the fault of the plug-in anyway.

Cheers,
Deepak



More information about the distro-pkg-dev mailing list