Reviewer needed - fix of regression test PrintAllXcheckJNI in IcedTea7

[Denis Lila]

Hi Pavel.

The fix looks good, but I would do

+        while (frame.getWidth() == 0 || frame.getHeight() == 0) {

instead of

+        while (frame.getWidth() == 0) {


The width probably can't be updated independently of the height,
but we can't be sure of this unless we spend a lot of time
reading the implementation. Just adding "|| frame.getHeight() == 0"
is more efficient ;-)

Regards,
Denis.

----- Original Message -----
> Hi all,
> 
> I've prepared fix for regression test PrintAllXcheckJNI for IcedTea7.
> This test now explicitly checks if frame is really displayed. Without
> this check the frame size is 0x0 for some time interval due to X-async
> behaviour and the test fails because BufferedImage (or Raster to be
> more
> precise) can not have zero-dimensions.
> 
> I'd like to push this fix to IcedTea7-forest, hg diff is stored in
> attachment.
> 
> Can anybody please review this change?
> 
> Thank you in advance,
> Pavel
> 
> 
> [Text File:hg_diff]