Reviewer needed - fix for regression test test/sun/net/www/protocol/file/DirPermissionDenied in IcedTea7

Pavel Tisnovsky ptisnovs at redhat.com
Fri May 20 00:32:17 PDT 2011


Dr Andrew John Hughes wrote:
> On 18:18 Mon 16 May     , Pavel Tisnovsky wrote:
>> Dr Andrew John Hughes wrote:
>>> On 11:57 Fri 13 May     , Pavel Tisnovsky wrote:
>>>> Dr Andrew John Hughes wrote:
>>> Yes, there's no ChangeLog in the forest.
>>>
>>> You'll need to make a change to IcedTea7 itself as well to bump the
>>> Mercurial revisions and checksums.  This will include a ChangeLog where
>>> you can detail the actual change.  See IcedTea7's ChangeLog for some
>>> examples from me.
>>>
>> Hi Andrew,
>>
>> thank you for the explanation, but I'm not sure how to "...bump the
>> Mercurial revisions and checksums...". It's probably interesting thing
>> that could be explained (or referenced) on the
>> http://icedtea.classpath.org/wiki/CommitPolicy page
>>
>> (I recall you mentioned that you have some useful script to do that work)
>>
> 
> How about:
> 
> "In IcedTea7, patches for OpenJDK are applied directly to our OpenJDK forest.
> Again, when conducting backports, use exact patches (via hg export/import) and
> do not mix in additional changes.
> 
> Once a change has been made to the forest, IcedTea7 needs to be
> updated to download the new changeset(s), which involves updating the
> changeset identifiers and checksums in Makefile.am.  A script called
> update_tarballs.sh is provided in the scripts subdirectory of the
> IcedTea7 repository for this purpose.  This is run by specifying the
> path to download the tarballs to as an argument.  If the tarballs
> have already been downloaded, gen_changeset_and_sha256sums.sh can
> be used directly to generate the changeset identifers and checksums.
> Once the script(s) have been run, the new values can be find in
> /tmp/changesets and /tmp/sums, ready for import into Makefile.am.
> The change to Makefile.am requires a ChangeLog entry as usual, and
> should describe the new changeset(s) being imported."
> 
> If that sounds fine, I'll add it to the wiki.

It's IMHO perfectly acceptable and understandable. Thank you.





More information about the distro-pkg-dev mailing list