Reviewer needed: fix for regression test test/java/lang/invoke/InvokeDynamicPrintArgs.java in IcedTea7-forest

[Pavel Tisnovsky]

Andrew John Hughes wrote:
> On Tue, May 24, 2011 at 05:08:17PM +0200, Pavel Tisnovsky wrote:
>> Hi all,
>>
>> Can anybody please review fix for regression test
>> test/java/lang/invoke/InvokeDynamicPrintArgs.java
>> for IcedTea7-forest? Original text contains imports from JUnit framework
>> and also @Test tag which is not needed for regression tests (it in fact
>> prevents the compilation).
>>
>> hg diff generated against recent IcedTea7-forest is stored in an attachment.
>>
>> ChangeLog entry:
>>
>> 2011-05-24  Pavel Tisnovsky  <ptisnovs at redhat.com>
>>
>>         * Makefile.am:
>>         (HOTSPOT_CHANGESET): Remove dependency of JUnit
>>         from regression test
>>         test/java/lang/invoke/InvokeDynamicPrintArgs.java
>>         (HOTSPOT_SHA256SUM): Likewise
>>
>> Thank you in advance for reviewing,
>> Pavel
> 
> If these patches are in OpenJDK7 already, then we'll get them when we bump to
> a newer release after the 1.14 release tomorrow.  I don't think we need to be
> backporting test fixes just for 1.14, so please just wait until these changes
> appear naturally.

Hi Andrew,

other patches I sent yesterday are really in OpenJDK7, but specifically
this fix was made by me, which means its not part of OpenJDK nor IcedTea.

I suppose someone probably just forgot to delete a JUnit specific code
from this test and it caused problems.

Cheers,
Pavel