distro-pkg-dev Digest, Vol 48, Issue 88:Reviewer needed: fix for regression test InvokeDynamicPrintArgs.java

[Chris Phillips]

Hi Pavel
This change looks ok, but the test InvokeDynamicPrintArgs.java
  was disabled in jdk7 recently.
(I'll see if I can find the changeset). I think the test is out of sync
with the current JSR 292 implementation now using Ricochet frames.

Chris
PS
Changeset:

Changeset: bd8c10d1db87
Author:    mduigou
Date:      2011-05-09 09:13 -0700
URL:http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/bd8c10d1db87

7043104: disable test java/lang/invoke/InvokeDynamicPrintArgs.java
Reviewed-by: alanb



On 24/05/11 03:00 PM, distro-pkg-dev-request at openjdk.java.net wrote:
> Date: Tue, 24 May 2011 17:08:17 +0200
> From: Pavel Tisnovsky<ptisnovs at redhat.com>
> Subject: Reviewer needed: fix for regression test
> 	test/java/lang/invoke/InvokeDynamicPrintArgs.java in IcedTea7-forest
> To: IcedTea<distro-pkg-dev at openjdk.java.net>
> Message-ID:<4DDBC9E1.6060004 at redhat.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Hi all,
>
> Can anybody please review fix for regression test
> test/java/lang/invoke/InvokeDynamicPrintArgs.java
> for IcedTea7-forest? Original text contains imports from JUnit framework
> and also @Test tag which is not needed for regression tests (it in fact
> prevents the compilation).
>
> hg diff generated against recent IcedTea7-forest is stored in an attachment.
>
> ChangeLog entry:
>
> 2011-05-24  Pavel Tisnovsky<ptisnovs at redhat.com>
>
>          * Makefile.am:
>          (HOTSPOT_CHANGESET): Remove dependency of JUnit
>          from regression test
>          test/java/lang/invoke/InvokeDynamicPrintArgs.java
>          (HOTSPOT_SHA256SUM): Likewise
>
> Thank you in advance for reviewing,
> Pavel
> -------------- next part --------------


-- 
**

--/      Woda: "Java: write once, debug anywhere" Hong Zhang
                      http://thehenrys.ca
  | Chris Phillips @ T O RedHat OpenJDK JVM Engineer,              |
  |mailto:ChPhilli at RedHat.Com                   (416)483-3768      |
  |http://LGonQn.Org/www/Chris.Phillips   cell: (416)505-3610      |
  "EPIC stands for Expects Perfectly Intuitive Compilers" P. Bannon
                   http://www.hazmatmodine.com
  NOTICE:

  This email message is for the sole use of the intended recipient(s)
  and may contain confidential and privileged information.  Any
  unauthorized review, use, disclosure or distribution is prohibited.
  If you are not the intended recipient, please contact the sender by
  reply email and destroy all copies of the original message.

                    "blah blah blah - Ginger!"/

Red Hat <http://www.redhat.com>
--

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110524/7aa06a84/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: RedHat.gif
Type: image/gif
Size: 1185 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110524/7aa06a84/RedHat.gif