[icedtea-web] RFC: PR724: Possible NullPointerException in JNLPClassLoader.getClassPathsFromManifest

[Omair Majid]

On 05/27/2011 11:30 AM, Deepak Bhole wrote:
> * Omair Majid<omajid at redhat.com>  [2011-05-27 11:26]:
>> Hi,
>>
>> The attached patch fixes PR724. It just adds more checking to handle
>> nulls gracefully. Okay to commit?
>>
>> ChangeLog:
>> 2011-05-27  Omair Majid<omajid at redhat.com>
>>
>>    * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
>>    (getClasspathsFromManifest): Handle nulls or empty strings properly.
>>
>> Cheers,
>> Omair
>
> Patch looks good to me. Okay for HEAD and branches (1.0 and 1.1).
>

Thanks for the review. I have pushed it to HEAD and 1.1. 1.0 does not 
contain the getClasspathsFromManifest method (and thus suffers from the 
bug fixed by changeset 6abf7a788f4e [1]), so this patch is not required 
there.

Cheers,
Omair

[1] 
http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=6abf7a788f4e