[icedtea-web] RFC: Patch to fix bug #723 (permission error with some jnlp apps)

[Deepak Bhole]

Hi,

Attached patch fixes error seen with the app at:
http://download.oracle.com/javase/tutorial/ui/overview/demo.html

Bug: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=723

ChangeLog:
2011-05-27  Deepak Bhole <dbhole at redhat.com>

    * netx/net/sourceforge/jnlp/cache/ResourceTracker.java
    (Downloader): Make class private.
    (Downloader::run): Call processResource via doPrivileged since resources 
    may get added at run time from application code via 
    JNLPClassLoader::addNewJar().

Okay for HEAD and 1.1?

Cheers,
Deepak
-------------- next part --------------
diff -r a92a625ced46 netx/net/sourceforge/jnlp/cache/ResourceTracker.java
--- a/netx/net/sourceforge/jnlp/cache/ResourceTracker.java	Wed May 25 15:12:18 2011 -0400
+++ b/netx/net/sourceforge/jnlp/cache/ResourceTracker.java	Fri May 27 16:51:38 2011 -0400
@@ -28,6 +28,8 @@
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.net.URLConnection;
+import java.security.AccessController;
+import java.security.PrivilegedAction;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.ConcurrentHashMap;
@@ -1078,7 +1080,7 @@
     /**
      * This class downloads and initializes the queued resources.
      */
-    class Downloader implements Runnable {
+    private class Downloader implements Runnable {
         Resource resource = null;
 
         public void run() {
@@ -1100,7 +1102,19 @@
                 }
 
                 try {
-                    processResource(resource);
+
+                    // Resource processing involves writing to files 
+                    // (cache entry trackers, the files themselves, etc.)
+                    // and it therefore needs to be privileged
+
+                    final Resource fResource = resource;
+                    AccessController.doPrivileged(new PrivilegedAction<Void>() {
+                        public Void run() {
+                            processResource(fResource);                            
+                            return null;
+                        }
+                    });
+
                 } catch (Exception ex) {
                     if (JNLPRuntime.isDebug())
                         ex.printStackTrace();