[icedtea-web] RFC: PR725

[Omair Majid]

Hi,

The attached patch fixes PR725.

The original bug was that a user would be prompted every time when 
starting a JNLP application for creating a desktop entry. This patch 
fixes it. With this patch, the user is only prompted for creating a 
desktop entry the first time a jnlp application is run.

Since we use desktop-file-install to install desktop entry files (which 
allows us to deal with a number of cases including renaming the 
~/Desktop dir), we can not get a list of all desktop entry files 
currently present. The patch takes an alternative approach and maintains 
a list of all applications it has seen already; the user is only 
prompted to install a desktop entry for those applications that the user 
is running for the first time.

I would like to add this to HEAD for now.

Any thoughts or comments?

ChangeLog:
2011-05-27  Omair Majid  <omajid at redhat.com>

   * netx/net/sourceforge/jnlp/config/Defaults.java: Add defaults for
   KEY_USER_DESKTOP_STORAGE_FILE.
   * netx/net/sourceforge/jnlp/config/DeploymentConfiguration.java: Add
   KEY_USER_DESKTOP_STORAGE_FILE
   * netx/net/sourceforge/jnlp/runtime/ApplicationInstance.java
   (addMenuAndDesktopEntries): Only make a decision about creating the
   desktop file the first time a jnlp application is run.
   * netx/net/sourceforge/jnlp/util/DesktopEntryStorage.java: New file.
   * netx/net/sourceforge/jnlp/util/XDesktopEntry.java
   (hashCode): New method.
   (cacheIcon): Add effect of method to javadoc.

Thanks,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea-web-do-not-prompt-repeatedly-for-creating-desktop-entries.patch
Type: text/x-patch
Size: 9920 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110527/2e381a9f/icedtea-web-do-not-prompt-repeatedly-for-creating-desktop-entries.patch