RFC: backport S7103224 to icedtea6

[Dr Andrew John Hughes]

On 19:07 Wed 26 Oct     , Omair Majid wrote:
> On 10/26/2011 06:53 PM, Dr Andrew John Hughes wrote:
> > On 17:41 Wed 26 Oct     , Omair Majid wrote:
> >> Hi,
> >>
> >> I would like to backport the fix for 7103224 to icedtea6. This bug
> >> allows icedtea6 to be built with (very) new glibc versions. Please see
> >> the original email for details:
> >> http://mail.openjdk.java.net/pipermail/hotspot-dev/2011-October/004589.html
> >>
> >> I have attached the patches for IcedTea6 HEAD and 1.10.
> >>
> >> ChangeLog:
> >> 2011-10-25  Omair Majid<omajid at redhat.com>
> >>
> >>      * patches/openjdk/7103224-glibc_name_collision.patch: New file.
> >>      * Makefile.am (ICEDTEA_PATCHES): Add the above.
> >>
> >> Does anyone have any thoughts or concerns?
> >>
> >
> > This patch seems to do more than the summary says.  Why
> > is MAXFLOAT being removed for example?
> >
> 
> Someone from Apple pointed out another name clash between MAXFLOAT and 
> the Apple compilers/libc [1] very soon after I posted my patch. I guess 
> it's too much of a hassle to create a separate bug for a one-line fix 
> removing MAXFLOAT and so Tom decided to combine the changes [2]. As 
> mentioned in the email, MAXFLOAT is not used anywhere so removing it 
> should be fairly safe.
> 

Ok, sounds fine.

> > You can commit to HEAD without approval.  I suggest you do
> > this and let it soak for some time before backporting to
> > 1.10.
> >
> 
> Sure. I think we will be applying this patch in Fedora locally then; it 
> is causing icedtea6-1.10.4 (the security update!) builds to fail for F16 :(
> 

I'm very surprised this glibc change was allowed in F16 after it's supposed
to have reached beta...

> > What about 7 HEAD and 7 2.0?
> >
> 
> Unfortunately, my machine cant handle too many concurrent icedtea builds 
> :) I will post patches after I have built and tested icedtea7.
> 
> Thanks,
> Omair
> 
> [1] 
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2011-October/004591.html
> [2] 
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2011-October/004594.html

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20111107/b3834a77/attachment.bin