[RFC][icedtea6] RH683768: Tray icons for applications are not displayed in the GNOME notification bar.

[Danesh Dadachanji]

Hi,

On 15/11/11 02:47 PM, Dr Andrew John Hughes wrote:
> On 17:39 Mon 14 Nov     , Danesh Dadachanji wrote:
>> Hi,
>>
>> Here's a patch to fix java tray icons not showing on GNOME 3. It fixes
>> RH683768[1]/part of another bug reported on Oracle's bug database[2].
>> It's been pushed into openjdk8 and I'm going to ask that it be
>> backported to 6 and 7. In the mean time, I'd like to get it into
>> icedtea{6,7} HEAD.
>>
>> The attached patch is for icedtea6, tested on Fedora 15 with GNOME Shell
>> 3.0.2. Once I sort out build issues, I'll post a (similar) patch for
>> icedtea7-forest/jdk.
>>
>> ChangeLog:
>> +2011-11-14  Danesh Dadachanji<ddadacha at redhat.com>
>> +
>> + * Makefile.am:
>> +   (ICEDTEA_PATCHES): Add patches/openjdk/683768-System-tray-icon.patch
>> + * NEWS: Updated.
>> + * patches/openjdk/683768-System-tray-icon.patch: New file. Sets XAtoms
>> +   _NET_WM_PID and WM_CLIENT_MACHINE for X windows.
>> +
>>
>>
>> Regards,
>> Danesh
>>
>> [1] https://bugzilla.redhat.com/show_bug.cgi?id=683768
>> [2] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7103610
>
>
> Looks good to me.
>

Thanks for the review! I noticed some extra indentations in the 
ChangeLog entry. I've removed them and pushed to HEAD.

http://icedtea.classpath.org/hg/icedtea6/rev/15d88aeb3dc4

Regards,
Danesh