[RFC][icedtea-web] emma and testcoveragefor testsuites

[Jiri Vanek]

On 11/28/2011 07:25 PM, Omair Majid wrote:
> On 11/28/2011 11:44 AM, Jiri Vanek wrote:
>> TYVM for review!
>>

>> I have added exit -5. Enough?
>
> Exit codes are normally in the range [0,255].

Changed to... positive, to... eg 5. ok?

>>>> + rm -f $(UNIT_CLASS_NAMES)
>>>> + -rm -f run-unit-test-code-coverage
>>>> + -rm -f run-netx-unit-tests
>>>
>>> Is the "-" in "-rm" required? -f means force so rm should not fail if
>>> the file is missing.
>> Yes, it was required
>
> I am quite surprised. Do you have a way to reproduce this?
I have not explained it enough - it was required because I wrote clean badly - it tried to remove coverage reports during each clean-tests, so it was failing if (mostly) coverage was not run. Now, when Each coverage have its conditional celan it is much cleaner and better.
>
>>>
>>>> rm -f stamps/netx-unit-tests-compile.stamp
>>>>
>>>> clean_tests_reports:
>>>> @@ -629,7 +793,10 @@
>>>> rm -f stamps/netx-dist-tests-sign-some-reproducers.stamp
>>>> rm -f junit-jnlp-dist-simple.txt
>>>> rm -f junit-jnlp-dist-signed.txt
>>>> + rm -f $(REPRODUCERS_CLASS_NAMES)
>>>> rm -f $(abs_top_builddir)/$(KEYSTORE_NAME)
>>>> + -rm -f run-reproducers-test-code-coverage
>>>> + rm -f stamps/run-netx-dist-tests
>>>>
....
>> cd $(JNLP_TESTS_ENGINE_DIR) ; \
>> class_names= ; \
>> @@ -548,7 +553,7 @@
>> class_name=`echo $$class_name | sed -e 's|/|.|g' ` ; \
>> class_names="$$class_names $$class_name" ; \
>> done ; \
>> - echo $$class_names ; \
>> + echo $$class_names> $(REPRODUCERS_CLASS_NAMES) ; \
>
> Can we also make this a separate target?

Done.

>
> Cheers,
> Omair

2011-11-28 Jiri Vanek <jvanek at redhat.com>
	Added code-coverage generation targets
	* configure.ac: added search for optional emma.jar
	* makefile.am: added UNIT_CLASS_NAMES and REPRODUCERS_CLASS_NAMES variables
	to store tests clases for reuse in emmarun. Both also moved to separate target
	(run-netx-unit-tests): made dependent on reused stamped version
	(run-netx-dist-tests): made dependent on reused stamped version
	(stamps/run-netx-dist-tests): stamped rusable version of run-netx-dist-tests
	(run-unit-test-code-coverage) targets to generate report from unit-tests.
	 Result binary and xml file and html report in tests.build/netx/unit
	(run-reproducers-test-code-coverage) targets to generate report from
	 reproducers-test. Result binary file, xml and html report in
	 tests.build/netx/jnlp_testsengine
	(run-test-code-coverage): merges binary results from unit and reproducers
	(clean-unit-test-code-coverage) conditionaly removes html,xml report
	 and es and ec files from tests.build/netx/unit
	(clean-reproducers-test-code-coverage) condtionlay removes html and xml
	 report and es file from  tests.build/netx/jnlp_testsengine
	(clean-test-code-coverage) conditionlay removes merged html, xml es and em
	files from tests.build
	(clean-netx-tests) now depends also on clean-test-code-coverage


-------------- next part --------------
A non-text attachment was scrubbed...
Name: testCoverageUponHead4.diff
Type: text/x-patch
Size: 18742 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20111129/769d1413/testCoverageUponHead4.diff