/hg/icedtea-web: 4 new changesets

[Jiri Vanek]

On 09/27/2011 03:14 AM, Dr Andrew John Hughes wrote:
> On 15:25 Mon 26 Sep     , Omair Majid wrote:
>> On 09/26/2011 03:10 PM, Dr Andrew John Hughes wrote:
>>> On 13:54 Mon 26 Sep     , Omair Majid wrote:
>>>> On 09/22/2011 12:05 PM, jvanek at icedtea.classpath.org wrote:
>>>>
>>>>> changeset c438d6a9c7a9 in /hg/icedtea-web
>>>>> details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=c438d6a9c7a9
>>>>> author: Jiri Vanek<jvanek at redhat.com>
>>>>> date: Thu Sep 22 17:53:48 2011 +0200
>>>>>
>>>>> 	added first signed reproducer as example and testing read properties
>>>>> 	signed behaviour.
>>>>>
>>>>>
>>>>> changeset 9b2205c224d4 in /hg/icedtea-web
>>>>> details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=9b2205c224d4
>>>>> author: Jiri Vanek<jvanek at redhat.com>
>>>>> date: Thu Sep 22 18:01:24 2011 +0200
>>>>>
>>>>> 	Added test (into signed reproducers) which is trying to missuse
>>>>> 	xtrustAll by reflection and to laod unsigned code. This test pass,
>>>>> 	if loading unsigned jar will fail (because accessing of inner netx
>>>>> 	classes is avaiable by with reflection).
>>>>>
>>>>>
>>>>> diffstat:
>>>>>
>>>>>     ChangeLog                                                        |   55 +++++
>>>>>     Makefile.am                                                      |  100 +++++++--
>>>>>     acinclude.m4                                                     |   58 +++++
>>>>>     configure.ac                                                     |    2 +
>>>>>     netx/net/sourceforge/jnlp/runtime/Boot.java                      |    3 +
>>>>>     netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java           |    3 +
>>>>>     netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java               |   12 +
>>>>>     netx/net/sourceforge/jnlp/security/VariableX509TrustManager.java |    4 +
>>>>>     tests/jnlp_tests/README                                          |   12 +-
>>>>>     tests/jnlp_tests/simple/ReadProperties/srcs/ReadProperties.java  |    4 +-
>>>>>     10 files changed, 221 insertions(+), 32 deletions(-)
>>>>>
>>>>
>>>> Looking at the diffstat, nothing was added to tests/jnlp_tests/signed/.
>>>> In fact, that directory does not even exist in the current HEAD.
>>>>
>>>> Because the signed directory does not exist, the makefile creates
>>>> incorrect files:
>>>>
>>>> junit-jnlp-dist-signed.txt:
>>>>        cd $(JNLP_TESTS_SRCDIR)/signed/ ; \
>>>>        find .  -maxdepth 1 -mindepth 1 | sed "s/.\/*//">
>>>> $(abs_top_builddir)/$@
>>>>
>>>> If singed dir is not present, this creates a junit-jnlp-dist-signed.txt
>>>> that contains a list of files in $(abs_top_builddir). Running this
>>>> "test" shows lots of output that is quite meaningless.
>>>>
>>>> Could you please add the missing files?
>>>>
>>>
>>> I see four changesets here.  Have they all been reviewed?
>>>
>>
>> Yes, I went over the patches [1] and everything looked fine to me.
>>
>> Cheers,
>> Omair
>>
>> [1]
>> http://thread.gmane.org/gmane.comp.java.openjdk.distro-packaging.devel/15675
>
> Yes, I saw that.  I don't see why it resulted in four changesets rather than one.



I beg my pardon and I thank you for catching it. I do not know how it slipped from my commit:-/

Fixing now by pushing in same shape as it have been reviewed.


J.