/hg/icedtea6: 2011-10-03 Xerxes Ranby <xerxes at zafena.se>

[xranby at icedtea.classpath.org]

changeset 23b9bb41de6d in /hg/icedtea6
details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=23b9bb41de6d
author: Xerxes Ranby <xerxes at zafena.se>
date: Mon Oct 03 16:35:35 2011 +0200

	2011-10-03 Xerxes Ranby <xerxes at zafena.se> Robert
	Lougher <rob at jamvm.org.uk>

	 *
	pulseaudio/src/native/org_classpath_icedtea_pulseaudio_Stream.c
	(Java_org_classpath_icedtea_pulseaudio_Stream_native_1pa_1stream_1ge
	t_1buffer_1attr): Make code compliant to the JNI
	specification. Enable pulseaudio to work in combination
	with JVM that strictly implement JNI spec.

	The code is not compliant to the JNI specification. FindClass takes
	a fully-qualified classname :

	http://download.oracle.com/javase/6/docs/technotes/guides/jni/spec/f
	unctions.html

	name: a fully-qualified class name (that is, a package name,
	delimited by ?/?, followed by the class name). If the name begins
	with ?[? (the array signature character), it returns an array class.
	The string is encoded in modified UTF-8.

	The code above is giving a type signature (qualified name inside 'L'
	and ';'). HotSpot is obviously allowing this. But this not correct
	according to the specification.

	Rob.


diffstat:

 ChangeLog                                                       |  9 +++++++++
 pulseaudio/src/native/org_classpath_icedtea_pulseaudio_Stream.c |  2 +-
 2 files changed, 10 insertions(+), 1 deletions(-)

diffs (28 lines):

diff -r 80aee2097f5e -r 23b9bb41de6d ChangeLog
--- a/ChangeLog	Mon Oct 03 13:07:54 2011 +0200
+++ b/ChangeLog	Mon Oct 03 16:35:35 2011 +0200
@@ -1,3 +1,12 @@
+2011-10-03  Xerxes RÃ¥nby  <xerxes at zafena.se>
+	    Robert Lougher <rob at jamvm.org.uk>
+
+	* pulseaudio/src/native/org_classpath_icedtea_pulseaudio_Stream.c
+	  (Java_org_classpath_icedtea_pulseaudio_Stream_native_1pa_1stream_1get_1buffer_1attr):
+	  Make code compliant to the JNI specification.
+	  Enable pulseaudio to work in combination with JVM that strictly
+	  implement JNI spec.
+
 2011-10-03  Xerxes RÃ¥nby  <xerxes at zafena.se>
 	    David Henningsson <david.henningsson at canonical.com>
 	    Matthias Klose <doko at ubuntu.com>
diff -r 80aee2097f5e -r 23b9bb41de6d pulseaudio/src/native/org_classpath_icedtea_pulseaudio_Stream.c
--- a/pulseaudio/src/native/org_classpath_icedtea_pulseaudio_Stream.c	Mon Oct 03 13:07:54 2011 +0200
+++ b/pulseaudio/src/native/org_classpath_icedtea_pulseaudio_Stream.c	Mon Oct 03 16:35:35 2011 +0200
@@ -895,7 +895,7 @@
     const pa_buffer_attr* buffer = pa_stream_get_buffer_attr(stream);
     assert(buffer);
 
-    const char* class_name = "Lorg/classpath/icedtea/pulseaudio/StreamBufferAttributes;";
+    const char* class_name = "org/classpath/icedtea/pulseaudio/StreamBufferAttributes";
     jclass cls = (*env)->FindClass(env, class_name);
     assert(cls);
     jmethodID constructor_mid = (*env)->GetMethodID(env, cls, "<init>", "(IIIII)V");