[IcedTea6 1.9] RFC: Add support for libpng 1.5

Omair Majid omajid at redhat.com
Mon Oct 17 08:26:31 PDT 2011


On 10/12/2011 08:14 PM, Dr Andrew John Hughes wrote:
> On 00:30 Thu 13 Oct     , Dr Andrew John Hughes wrote:
>> I'd like to get this into 1.9 as well.  It's not a showstopper, but,
>> as I'm having to apply it to 1.9 to do builds now, I'd prefer we
>> were releasing the same thing as is being built.
>>
>> The functions used seem pretty old, and all three are in the in-tree
>> version of libpng.  So if you don't have them, you must be using a
>> system libpng older than the version Oracle test against.
>>
>> The functions are:
>>
>> png_get_io_ptr
>> png_jmpbuf
>> png_set_read_fn
>>
>> and, at least for png_get_io_ptr, the libpng documentation says:
>>
>> "The png_get_io_ptr() function has been present since libpng-0.88, has
>> never changed, and is unaffected by conditional compilation macros."
>>
>> Ok for 1.9?
>>
>
> Alternatively, we could use the attached patch to be on the safe side,
> only changing those lines if 1.5 or above is used.

Looks good to me.

Cheers,
Omair



More information about the distro-pkg-dev mailing list