IcedTea6 "make clean" doesn't work

[Dr Andrew John Hughes]

On 18:31 Wed 19 Oct     , Andrew Haley wrote:
> It seems to be because of this hunk, which adds jtregcheck as a dependency
> of clean-local:
> 
> @@ -629,7 +641,7 @@
>   clean-icedtea-against-ecj clean-extract-ecj clean-generated clean-replace-hotspot \
>   clean-rewriter clean-rewrite-rhino clean-rt clean-bootstrap-directory \
>   clean-bootstrap-directory-ecj clean-bootstrap-directory-symlink \
> - clean-bootstrap-directory-symlink-ecj clean-fonts
> + clean-bootstrap-directory-symlink-ecj clean-fonts jtregcheck
>         if [ -e bootstrap ]; then \
>           rmdir bootstrap ; \
>         fi
> @
> 
> As a result, "make clean" downloads a ton of stuff.
> Surely this must have been a mistake?  Why would anyone want to do this?
> 

Looks like a mistake caused by the fact that .PHONY and clean-local are similar
and the original patch (backported from 7) added jtregcheck to .PHONY.  I suspect
patch changed the wrong line because they look similar.

Thanks for spotting.

> Andrew.
> 
> 
> # HG changeset patch
> # User Andrew John Hughes <ahughes at redhat.com>
> # Date 1317833793 -3600
> # Node ID cbceaa3d9fdf417d9c8bbad09c69904eb990b4bd
> # Parent  249af20382328fad27528f2d904c909555885c80
> Allow all or individual test suites to be disabled.
> 
> 2010-07-18  Andrew John Hughes  <ahughes at redhat.com>
> 
>         Allow all or individual test suites to be
>         disabled.
>         * Makefile.am:
>         (TEST_SUITES): Test suites to run.
>         (TESTS_TO_RUN): Dependencies of jtregcheck.
>         (check-local): Re-enable.
>         (.PHONY): Add jtregcheck.
>         (jtregcheck): Use TEST_SUITES and TESTS_TO_RUN.
>         * acinclude.m4:
>         (IT_DISABLE_TESTS): New option to allow all tests
>         to be turned off.
>         (IT_DISABLE_HOTSPOT_TESTS): Likewise just for HotSpot tests.
>         (IT_DISABLE_LANGTOOLS_TESTS): Likewise just for langtools tests.
>         (IT_DISABLE_JDK_TESTS): Likewise just for JDK tests.
>         * configure.ac:
>         Call new macros.
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20111019/4356712b/attachment.bin