[icedtea-web] RFC: PR788: Elluminate Live! is not working

[Jiri Vanek]

On 10/20/2011 08:49 PM, Omair Majid wrote:
> On 10/20/2011 08:52 AM, Jiri Vanek wrote:
>> Hi. This is reproducer for this fix which Omair posted some time ago.
>> When I was creating this simple behaviour, I was surprised that some
>> cases are falling.
>
> Thanks for creating the tests!
>
>> The reproducer contains one "signed jar" and four testing jnlp files and
>> four tests. It is surprise, that jnlp/test id numbers 2 and 4 are
>> failing. From this is obvious, that difference between tests is only in
>> order of loaded jars in jnlp. I consider this behaviour as *bug*.
>
> Agreed, that certainly sounds like a bug.
>
>> diff -r f1468696eda3 tests/jnlp_tests/signed/MissingJar/resources/MissingJar4.jnlp
>> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
>> +++ b/tests/jnlp_tests/signed/MissingJar/resources/MissingJar4.jnlp Thu Oct 20 14:26:14 2011 +0200
>> @@ -0,0 +1,18 @@
>> +<?xml version="1.0" encoding="utf-8"?>
>> +<jnlp spec="1.0"
>> + codebase="./"
>> + href="MissingJar4.jnlp">
>> +<information>
>> +<title>test MissingJar</title>
>> +</information>
>> +<resources>
>> +<jar href="MissingOne.jar" />
>> +</resources>
>> +<resources>
>> +<jar href="MissingJar.jar" main="true" />
>> +</resources>
>> +<application-desc main-class="MissingJar"/>
>> +<security>
>> +<all-permissions/>
>> +</security>
>> +</jnlp>
>
> Would it be possible to rename the jars to make it clear which one of the two exists and which one doesn't?
>

Renamed... O:)

>> + @Test
>> + public void MissingJarTest3() throws Exception {
>> + System.out.println("connecting MissingJar3 request");
>> + System.err.println("connecting MissingJar3 request");
>> + ServerAccess.ProcessResult pr = server.executeJavawsHeadless(l, "/MissingJar3.jnlp");
>> + evaluateResult(pr);
>> + }
>> + @Test
>> + public void MissingJarTest4() throws Exception {
>> + System.out.println("connecting MissingJar4 request");
>> + System.err.println("connecting MissingJar4 request");
>> + ServerAccess.ProcessResult pr = server.executeJavawsHeadless(l, "/MissingJar4.jnlp");
>> + evaluateResult(pr);
>
> The indentation looks a little off here.

fixed.

>
> Cheers,
> Omair

Btw... For speed up the code-coverage by unittest and reproducers, I think that directory "tests" should be taken out from review process duty for new tests. What do you think?

J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: missngJar2.diff
Type: text/x-patch
Size: 10658 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20111024/042e5c35/missngJar2.diff