Reviewer needed: backport of "5082756: Image I/O plug-ins set metadata boolean attributes to "true" or "false" into IcedTea6 HEAD

[Pavel Tisnovsky]

Jiri Vanek wrote:
> On 09/07/2011 11:24 AM, Pavel Tisnovsky wrote:
>> Greetings,
>>
>> I'd like to push backport of '5082756: Image I/O plug-ins set metadata
>> boolean
>> attributes to "true" or "false"' into IcedTea6 HEAD. Tested on RHEL 5
>> x86_64 -
>> this backport does not break API compatibility and the regression test
>> contained
>> in the backport works properly.
>>
>> Mercurial diff created against recent IcedTea6 HEAD is stored in an
>> attachment.
>>
>> ChangeLog entry:
>>
>> 2011-09-06  Pavel Tisnovsky<ptisnovs at redhat.com>
>>
>>          * Makefile.am: added new patch
>>          * NEWS: updated with backport
>>          *
>> patches/openjdk/5082756-ImageIO_plugins_metadata_boolean_attributes.patch:
>>
>>          Backport of 5082756: Image I/O plug-ins set metadata
>>          boolean attributes to "true" or "false"
>>
>> Can anybody please review this patch please?
>>
>> Thank you in advance,
>> Pavel
> Maybe typo in changelog  - true and false should be in capital letters?
> Otherwise changes looks ok for me.
> Thanx for nice "teaching" patches
> 
> J.

Hi Jiri,

name of the fix is AFAIK correct because it's name is based on bug description
from Oracle database. Ie the bug caused that image metadata represents boolean
attributes as "true" and "false" strings and it was corrected to "TRUE" and
"FALSE" by this fix (as is defined in DTD).

Pavel