Reviewer needed: backport of "5082756: Image I/O plug-ins set metadata boolean attributes to "true" or "false" into IcedTea6 HEAD

Pavel Tisnovsky ptisnovs at redhat.com
Thu Sep 8 02:37:36 PDT 2011


Dr Andrew John Hughes wrote:
> On 11:24 Wed 07 Sep     , Pavel Tisnovsky wrote:
>> Greetings,
>>
>> I'd like to push backport of '5082756: Image I/O plug-ins set metadata boolean
>> attributes to "true" or "false"' into IcedTea6 HEAD. Tested on RHEL 5 x86_64 -
>> this backport does not break API compatibility and the regression test contained
>> in the backport works properly.
>>
>> Mercurial diff created against recent IcedTea6 HEAD is stored in an attachment.
>>
>> ChangeLog entry:
>>
>> 2011-09-06  Pavel Tisnovsky  <ptisnovs at redhat.com>
>>
>>         * Makefile.am: added new patch
>>         * NEWS: updated with backport
>>         * patches/openjdk/5082756-ImageIO_plugins_metadata_boolean_attributes.patch:
>>         Backport of 5082756: Image I/O plug-ins set metadata
>>         boolean attributes to "true" or "false"
>>
>> Can anybody please review this patch please?
>>
>> Thank you in advance,
>> Pavel
> 
> This looks fine.  Do the tests pass?
> 

Yes, the new test (BooleanAttributes.java) and also the patched test
(ITXtTest.java) pass.



More information about the distro-pkg-dev mailing list