[icedtea-web][rfc] make current reproducers more verbose
Deepak Bhole
dbhole at redhat.com
Wed Sep 14 11:31:25 PDT 2011
* Jiri Vanek <jvanek at redhat.com> [2011-09-12 14:28]:
> On 09/12/2011 08:09 PM, Deepak Bhole wrote:
> >* Jiri Vanek<jvanek at redhat.com> [2011-09-12 14:07]:
> >>2011-09-12 Jiri Vanek<jvanek at redhat.com>
> >> * tests/jnlp_tests/: all current reproducers (AccessClassInPackage
> >> AddShutdownHook AllStackTraces CreateClassLoader deadlocktest
> >> ReadEnvironment ReadProperties RedirectStreams ReplaceSecurityManager
> >> SetContextClassLoader simpletest1 simpletest2) junit's asserts are enchanted
> >> for reason, so junit assertion exception message is much clearer.
> >
> >Hi Jiri,
> >
> >What issue does this fix? How do I reproduce it?
> >
> >Cheers,
> >Deepak
> >
>
> It fixs "nothing". But when something goes wrong you will be informed instead of standart "assertion error".
> You can reproduce behaviour when you will break some reproducer (but keep it compilable).
> I got to troubles here when I wrote scripts for including icedtea-web into daily report and I simulated failures - it was quite digging to find what and why got wrong. Now it is much easier.
>
> Thanx for looking into it!
Ah thanks. I can see the difference with and without the patch. Looks
fine to me. One minor nitpick .. the ChangeLog entry needs a newline
between the header and the next line. i.e.:
----
2011-09-12 Jiri Vanek <jvanek at redhat.com>
* tests/jnlp_tests/: all current reproducers
...
----
to
----
2011-09-12 Jiri Vanek <jvanek at redhat.com>
* tests/jnlp_tests/: all current reproducers
...
----
After above change, OK for HEAD.
Cheers,
Deepak
More information about the distro-pkg-dev
mailing list