[RFC][icedtea-web] extend reproducers engine for signed applications

[Omair Majid]

On 09/22/2011 08:52 AM, Jiri Vanek wrote:

> done ( I hope all formating issues are now ok.)

I can still see a few formatting problems. Could you please fix them?

> Changes to last patch
> -formatting issues
> -removed empty constructors
> -added again xtrustAllHack
>
> In your responses there is no criticism for xtrustAll patch. Is it ok to
> push? Also in last response there is no criticism of signed reproducers
> engine itself - ok to push?

After fixing changelog (explained below), and the formatting issues, 
please go ahead and commit.

>
> changelogs:
>

Please wrap changelogs at 80 columns. There should be a space between * 
and the file name. You might also find the docs at
http://herbert.the-little-red-haired-girl.org/html/standards/standards_6.html#SEC31 
useful.

> signedReproducersEngine:
> 2011-09-22  Jiri Vanek <jvanek at redhat.com>
>
>      Added signed reproducers engine
>      *Makefile.am added variable KEYSTORE_NAME
>      (stamps/junit-jnlp-dist-dirs): creates stamp and depend on next two
> targets
>      (junit-jnlp-dist-simple.txt): creates list of simple reproducers,
> extracted from ^
>      (junit-jnlp-dist-signed.txt): creates list of signed reproducers
>      (stamps/netx-dist-tests-prepare-reproducers.stamp): now traverse
> over signed and simple
>      (stamps/netx-dist-tests-sign-some-reproducers.stamp): depends on ^,
> traverse through signed reproducers and sign them

Please try and avoid '^'.

>      (stamps/netx-dist-tests-compile-testcases.stamp): now traverse over
> signed and simple
>      (stamps/bootstrap-directory.stamp): creates symlinks/stubs to
> jarsigner and keytool
>      (clean-netx-dist-tests):remove new stamps, signed and simple list
> and keysstore
>      *acinclude.m4: declared to proceed IT_FIND_KEYTOOL and
> IT_FIND_JARSIGNER macro
>      *configure.ac: declared macros to check for keytool and jarsigner
>      *tests/jnlp_tests/README: mentioned signed directory
>
> xtrustAll:
> 2011-09-22  Jiri Vanek <jvanek at redhat.com>
>
>      *netx/net/sourceforge/jnlp/runtime/Boot.java: (main): added logic
> to handle -Xtrustall option
>      *netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java: declared
> private static boolean trustAll=false; with public getter and
> pkg.private  setter
>      *netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java:
> (checkTrustWithUser): modified, when XtrustAll declared, then user is
> not asked and certificate is trusted
>      *netx/net/sourceforge/jnlp/security/VariableX509TrustManager.java:
> (askUser): --||--
>

Not sure what --||-- means....

> +public class ReadPropertiesBySignedHack {
> +
> +    /**
> +    *some system property is expected as arg[0], eg user.name or user.home
> +    */
> +    public static void main(String[] args) throws Throwable {
> +           //security manager is not protecting us from accessing classes  from
> +           //net.sourceforge.jnlp.runtime via reflection
> +            Class c2= Class.forName("net.sourceforge.jnlp.runtime.JNLPRuntime");
> +            Field f2 = c2.getDeclaredField("trustAll");
> +            f2.setAccessible(true);
> +            f2.setBoolean(null, true);
> +            Method m2=c2.getDeclaredMethod("setTrustAll",Boolean.TYPE);
> +            m2.setAccessible(true);
> +            m2.invoke((Object) null, true );
> +            //but security manager is guarding us against lunching unsigned code
> +            //from signed archvive even if Xtrustall is on.
> +            Class c1= Class.forName("ReadProperties");
> +            Method m1=c1.getDeclaredMethod("main",args.getClass());
> +            m1.invoke((Object) null, (Object)args);
> +         }
> +

Formatting looks a little off (mixed 4 space and 8 space indentation?).

> diff -r e9a9792ee189 netx/net/sourceforge/jnlp/security/VariableX509TrustManager.java
> --- a/netx/net/sourceforge/jnlp/security/VariableX509TrustManager.java	Thu Sep 15 15:27:40 2011 +0200
> +++ b/netx/net/sourceforge/jnlp/security/VariableX509TrustManager.java	Thu Sep 22 14:29:14 2011 +0200
> @@ -53,6 +53,7 @@
>   import sun.security.validator.ValidatorException;
>
>   import com.sun.net.ssl.internal.ssl.X509ExtendedTrustManager;
> +import net.sourceforge.jnlp.runtime.JNLPRuntime;
>
>   import net.sourceforge.jnlp.security.SecurityDialogs.AccessType;
>
> @@ -382,6 +383,9 @@
>       private boolean askUser(X509Certificate[] chain, String authType,
>                               boolean isTrusted, boolean hostMatched,
>                               String hostName) {
> +         if (JNLPRuntime.isTrustAll()){
> +            return true;
> +        }

Formatting looks a little off here too.

>           return SecurityDialogs.showCertWarningDialog(
>                           AccessType.UNVERIFIED, null,
>                           new HttpsCertVerifier(this, chain, authType,
>

Cheers,
Omair