[icedtea-web] RFC: PR618 - Can't install OpenDJ, JavaWebStart fails with Input stream is null error.

[Omair Majid]

On 09/26/2011 08:38 PM, Dr Andrew John Hughes wrote:
> On 11:44 Mon 19 Sep     , Omair Majid wrote:
>> Hi,
>>
>> The attached patch fixes PR618. There is an old thread [1] that traces
>> the evolution of this patch.
>>
>> The patch tires to make sure that resources marked as 'lazy' are
>> searched too if a resource is not found.
>>
>> ChangeLog
>> 2011-09-19  Omair Majid<omajid at redhat.com>
>>
>>     PR618
>>     * NEWS: Update.
>>     * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
>>     (getResource): Rename to ...
>>     (findResource): New method.
>>     (findResources): If resource can not be found, search in lazy
>>     resources.
>>     (findResourcesBySearching): New method.
>>
>> Any thoughts or comments?
>>
>
> Sorry, I thought I replied to this.
>

No worries!

> My only comment was as to the addition of @Override; I don't think this
> is necessary and it can cause issues with older compilers (there's an
> issue with this, IcedTea6 1.8 and the last security patch for instance).
>

Unless I am mistaken, this particular @Override should be fine. Some 
older (1.5) compilers assume that @Override can not be used on methods 
that are implementing a method declared in an interface. But all 1.5+ 
compilers should work if a method marked as @Override is overriding a 
method in a superclass (which is what findResource and findResources are 
doing).

The bug you mentioned above was caused because I accidentally added 
@Override to a method implementing a method (retrieve) declared in an 
interface (URLJarFileCallBack).

An advantage of @Override is that it serves as a sanity check and causes 
an error if the superclass changes and the method in the superclass is 
renamed or never called.

I would be more than happy to change the patch if you insist, though.

> Otherwise, it's good to go.
>

Thanks,
Omair