[RFC] Fix IndexOutOfBoundException because of corrupted entry in recently_used file

[Jiri Vanek]

On 04/03/2012 12:07 PM, Thomas Meyer wrote:
> Am Montag, den 02.04.2012, 15:14 +0200 schrieb Jiri Vanek:
>> On 03/28/2012 02:41 PM, Thomas Meyer wrote:
..snip..
> I'm not sure what did lead to this state. I found this nasty
> constellation last friday. Maybe my browser crashed or something.
>
Probably:)
>> I have fixed lru cache once already (for throwing NonIntegerValue exception) but I have never seen
>> this error even when I was trying to corrupt cache, and I agree with you that this should be done in
>> CacheLRUWrapper. Can you please provide (plaintext is enough) some reproducer?
>
> While debugging this problem I found an entry in the recently_used file
> that looked like this:
>
> "1333048426514,0=/h"

yes. It is the same cause as I was fixing except in my case it died as "1333048426," or ""
>
>> If you will be willing to add this behaviour to
>> icedtea-web/tests/jnlp_tests/signed/CacheReproducer/testcases/CacheReproducerTest.java it will be
>> really great (You should do this according to commit policy O:) "IcedTea-Web code changes/new
>> feature should be accompanied with appropriate tests (JUnit class and/or reproducer). If no tests
>> are added/modified, changes should be accompanied with an explanation as to why. " O:)
>
> I will try this and post a patch the next days.
>
Thank you!
>>
..snip..
>
>> Then IndexOutOfBounds will be wrapped by LruCache exception and cache will be properly cleared.
>> However the cleanCache() method in CacheUtil will need small fixing after this too.
>
> Yes, probably.
>
>> What do you think?
>
> Sounds good to me.
>
Good. As I think the reason  is same and so same  solution will serve as fix the best.
> btw. can the tests in the "test/jnlp_tests" directory be put in a
> different directory and/or package, so I can add the "jnlp_tests"
> directory to the eclipse build directory and start all tests in this
> directory from the IDE? this works great for "test/netx/unit".
I'm afraid not. But the only difference is, taht you need to add each reproducer as three directories,
  which actually doesn't mind, because one is mostly working with _one_ reproducer - debugging/coding x netx/reproducer itself
When you will add resources/srcs/testcase direcptries, all should work in IDE as you expect.

I will refer you to http://icedtea.classpath.org/wiki/Reproducers page. If you will find something unclear there, please let me know. The page is pretty fresh.

>
>>
>>
>> Thank you in advance, and Tyvm for getting the issue!
>
> my pleasure.
>
> thomas
>


Best Regards J.