[RFC][icedtea-web] Use IcedTea as the vendor for all JNLPs in test suite

Omair Majid omajid at redhat.com
Tue Apr 3 12:27:13 PDT 2012


On 04/03/2012 03:13 PM, Danesh Dadachanji wrote:
> On 03/04/12 02:13 PM, Danesh Dadachanji wrote:
>> Hi,
>>
>> Many of the JNLPs in the test suite have various vendors (for no
>> particular reason). For the community's sake, I'd like to replace all
>> the ones under tests/jnlp_tests/ with IcedTea. I'm avoiding touching
>> the unit test ones because I'm not 100% sure the vendor's being
>> specified explicitly to be tested.
>>
>> This command should do the trick:
>> $ find ./icedtea-web/tests/jnlp_tests/ -name *\.jnlp -exec sed -ie
>> 's/<vendor>[A-Za-z0-9 ]*<\/vendor>/<vendor>IcedTea<\/vendor>/g' {} \;
>>
>> The attached patch has the result, the above worked as expected.
>>
> 
> Omair pointed out that I might as well change the homepage URL too, we
> decided on this page[1] on IRC. I think the testing subheading is a good
> location at which to point, thanks to Jiri for thinking of it!
> 
> Command was:
> 
> $ find ./icedtea-web/tests/jnlp_tests/ -name *\.jnlp -exec sed -ie
> 's/<homepage href=".*"\/>/<homepage
> href="http:\/\/icedtea.classpath.org\/wiki\/IcedTea-Web#Testing_IcedTea-Web"\/>/'
> {} \;
> 
> Any other comments?
> 

Looks okay to me. Just one question: are there any tests that check for
the value of homepage or vendor?

Thanks,
Omair



More information about the distro-pkg-dev mailing list