[rfc] [icedtea-web] make links

Jiri Vanek jvanek at redhat.com
Fri Apr 6 07:55:04 PDT 2012


Hi!

This is third from total of 5 patches which are introducing Tets For Applets[1]

This particular one is introducing  detection of browsers, linking the newly compiled plugin to 
detected ones and forwarding this information to testengine..

I know this linking by makefile is controversial, but it gives sense to me.
Yes  - I can link the plugin with browsers manually before tests' run (and yes, this can be done 
once for all the runs in future), but I think this is much more versatile and is much more 
straightforward and much better controllable and also more fool-proof. The question weather to 
*UNlink* is more accurate:) ( there is no unlink right now, but should be easily addable if requested.
Also when tests are run from makefile, then also all the possible preparation should be done from 
makefile. And this step is necessary. I have also introduced test weather linking is correct see 
private void testBrowser(Browser browser) calls in [2]

What I'm missing is When I have choose AC_CHECK_PROGS, then it does not support --with-val :-/ Is 
there any AC_CHECK_PROGS which allows to set with-val?
Becasue I will probably put rather --with-firefox=/my/preconfiguired/firefox instead of let it use 
my default one. Although Lynks is quite good alternative during tests runtime :)
Also this can be maybe intorduced as new patch later.

Best regards J.

[1] http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2012-March/017799.html
[2] 
http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120320/8ef6bdfe/browserTests-tests-0001.diff 
(btw, this page is partially corrupted - there is html test, and firefox is trying to translate it 
as html page :-/.. so see source rather :-/)


changelog:
2012-04-06  Jiri Vanek <jvanek at redhat.com>

	Added detection of installed browsers and added targets to create symbolic links from install dir
to browsers' plugin directories. Primarily for testing purposes
	*Makefile.am: (clean-local) optionally delets links' stamps
	(stamps/user-links.stamp) with alias (links) - new target for creating symlinks for all users. One
must be root to execute this target.
	(stamps/global-links.stamp) with alias (user-links) - new target for creating symlinks for logged
user only. Because opera is missing this feature, quite useless.
	*configure.ac: added basic check whether and which browsers are installed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: makeLinks.diff
Type: text/x-patch
Size: 5211 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120406/43d080ff/makeLinks.diff 


More information about the distro-pkg-dev mailing list