[fyi] [icedtea-web] xmx for emma

[Omair Majid]

On 04/10/2012 05:04 AM, Jiri Vanek wrote:
> On 04/09/2012 12:47 AM, Omair Majid wrote:
>> On 04/06/2012 11:31 AM, Jiri Vanek wrote:
> Hi Omair!
> Thanx for check:)
>>> Hi! Recently codecoverage have fallen on my test machines because of not
>>> enough heap space. I would like to increase its Xmx value (eg to 2g as
>>> I'm doing in this patch)
>>
>> Perhaps you might want to rename EMMA_XMX to EMMA_JAVA_ARGS? That would
>> allow us to add additional java arguments for emma in the future without
>> further changes.
> Yap. Why not:)
>>
>>> 2012-04-06  Jiri Vanek<jvanek at redhat.com>
>>>
>>>      jvms running emma enlarged max heap space
>>>      * Makefile.am: (stamps/run-unit-test-code-coverage.stamp),
>>
>> You should leave out the colon here.
>>
>>> (stamps/run-reproducers-test-code-coverage.stamp) and
>>
>> You should just use a "," instead of the "and" at the end of the line. I
>> believe that's the correct thing to do based on the GNU ChangeLog
>> guidelines.
>>
>>> (run-test-code-coverage) java emma calls have increased theirs -Xmx
>>> value
>>
>> Please use a colon here followed by what the new change does. How about
>> something like this:
>>
>> (run-test-code-coverage): Use a larger max heap size for emma.
>>
>> Cheers,
>> Omair
> 
> 2012-04-10  Jiri Vanek <jvanek at redhat.com>
                        ^
An extra space here please.

> 
>     * Makefile.am: EMMA_JAVA_ARGS, new variable for adjusting emma runs.
>     Currently set to -Xmx2G
                             ^
Please add a "." here

>     (stamps/run-unit-test-code-coverage.stamp),
>     (stamps/run-reproducers-test-code-coverage.stamp),
>     (run-test-code-coverage) Use EMMA_JAVA_ARGS in theirs emma runs.
                              ^
And a ":" here

> Better?

Yup, with the suggested modifications to the ChangeLog, looks fine to me.

Cheers,
Omair