ARM: JSR 292 MethodHandle support

[Andrew Hughes]

----- Original Message -----
> Hi,
> 
> Better late than never, included below is a review of Andrew's patch.
> 
> regards,
> 
> 
> Andrew Dinn
> -----------

snip...

>   * jdk/make/common/shared/Compiler-gcc.gmk
> 
> This was setting
> 
>    SHARED_LIBRARY_FLAG = -shared -mimpure-text
> 
> but the second flag is invalid for arm (or indeed anything other than
> SPARC according to the gcc manual). So it needs to be removed.
>

As mentioned on IRC, you need:

changeset:   5125:fb3a2cafc230
parent:      5097:c5b882dce0fe
user:        andrew
date:        Thu Mar 08 14:04:44 2012 +0000
files:       make/common/shared/Compiler-gcc.gmk src/share/demo/jvmti/compiledMethodLoad/sample.makefile.txt src/share/demo/jvmti/gctest/sample.makefile.txt src/share/demo/jvmti/heapTracker/sample.makefile.txt src/share/demo/jvmti/heapViewer/sample.makefile.txt src/share/demo/jvmti/hprof/sample.makefile.txt src/share/demo/jvmti/index.html src/share/demo/jvmti/java_crw_demo/sample.makefile.txt src/share/demo/jvmti/minst/sample.makefile.txt src/share/demo/jvmti/mtrace/sample.makefile.txt src/share/demo/jvmti/versionCheck/sample.makefile.txt src/share/demo/jvmti/waiters/sample.makefile.txt
description:
7150392: Linux build breaks with GCC 4.7 due to unrecognized option
Summary: Remove -mimpure-text option.
Reviewed-by: ohair, dholmes, phh, andrew
Contributed-by: Deepak Bhole <dbhole at redhat.com>

This only seems to be in OpenJDK8 and not been followed through to relevant branches.
I've pushed it to IcedTea7 and will request an approval for jdk7u.
I pre-approve you adding it to 2.1.
 
>   * jdk/make/jdk_generic_profile.sh
> 
> This script needs an entry for arm in the case switch at line 283
> i.e.
> 
>     # ZERO_ENDIANNESS is the endianness of the processor
>     case "${ZERO_LIBARCH}" in
> -    i386|amd64|ia64)
> +    i386|amd64|ia64|arm)
> 
> and also another case at line 310 i.e.
> 
>       s390)
>         ZERO_ARCHFLAG="-m31"
>         ;;
> +    arm)
> +      ZERO_ARCHFLAG="-D_LITTLE_ENDIAN"
> +      ;;
>       *)
> 

This file is not used by the IcedTea build system which is, I guess, why these
haven't been updated.  Any changes need to go to both IcedTea7 and 2.0 & 2.1 branches.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07