[RFC][icedtea-web] Fix for PR855: AppletStub getDocumentBase() doesn't return full URL

[Danesh Dadachanji]

On 03/02/12 03:23 PM, Danesh Dadachanji wrote:
> Hi,
>
> This patch is a fix for PR855[1]. The return of getDocumentBase() currently doesn't include the HTML file. According to the docs, it
> should return the entire path of the HTML, including the filename.
>
> Attached is a patch that adds this. I've checked all the traces of the bytes grabbed from the pipe over on the java side. I believe I
> covered every read and assignment of the buffer/vars setup from the buffer and so on. We fortunately only ever used getDocumentBase()'s
> return to grab the host IP or use it as a base URL. The latter code grabbed the return and cut off everything after the last '/', which
> back before patch is the entire URL, post patch is the URL excluding the file name.
>
> Okay for HEAD? Thoughts on backporting to release branches? It was reported against 1.1.3 but this is a pretty big change that
> potentially affects the way users' applications behave.
>
> +2012-02-03 Danesh Dadachanji <ddadacha at redhat.com>
> +
> + PR855: AppletStub getDocumentBase() doesn't return full URL
> + * plugin/icedteanp/IcedTeaNPPlugin.cc (plugin_get_documentbase): Fixed
> + location string storing the document base to include the HTML file.
> +
>
> Regards,
> Danesh
>
> [1] http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=855

Ping?