[rfc][icedtea-web] signed applets test

[Jiri Vanek]

On 04/17/2012 08:31 PM, Danesh Dadachanji wrote:
>
>
> I missed a few last time. Sorry :S

Apologise on my side, thanx for precession.
>
> +2012-04-11  Jiri Vanek <jvanek at redhat.com>
> +
> +    Allowed signed appletes in automatic reproducers tests
>
> s/appletes/applets
>
> +    * tests/jnlp_tests/signed/AppletTestSigned/resources/AppletTestSigned.html:
> +    html file for launching signed applet. It still is different from the one for
> +    calling unsigned applets - red.
>
> Is the " - red" bit at the end still relevant? In fact, I think the entire sentence isn't quite
> necessary anymore. I think we can recognize that if it's for launching a signed applet, it'd be a
> different page than launching an unsigned one. =)
>
> IMO, "html file for launching signed applet." is enough. It's up to you if you want to keep it
> though. =)

I have kept it in with one correction which escaped you and maybe give more sense -   It still -> 
It's style
>
> +    * tests/jnlp_tests/signed/AppletTestSigned/resources/AppletTestSigned.jnlp:
> +    jnlp file for lunched signed applet
>
> s/lunched/launched
>
>>> > diff -r cde6d59a2901 Makefile.am
>>> > --- a/Makefile.am Thu Apr 05 10:57:16 2012 -0400
>>> > +++ b/Makefile.am Wed Apr 11 11:32:36 2012 +0200
>>> > @@ -23,6 +23,12 @@
>>> > JNLP_TESTS_SERVER_DEPLOYDIR=$(TESTS_DIR)/jnlp_test_server
>>> > JNLP_TESTS_DIR=$(TESTS_DIR)/jnlp_tests
>>> > KEYSTORE_NAME=teststore.ks
>>> > +KEYSTORE_PASS=123456789
>>>
>>> I'm curious, why was this password chosen over the regular "changeit"? I know that you're getting it
>>> from below but I'm wondering if anyone knows why the original dev chose this over the normal one. I
>>> would rather it be "changeit" for consistency's sake though. What do you think?
>>>
>
> I don't think you noticed this comment last time, any thoughts?
Ah! I noticed, I thought about it and I forgot to wrote it.

I chose this password :) It is private testing repository generated, filed and deleted during 
reproducers run.And so it have also some unimportant password.
I have renamed the variables to give more sense.
PRIVATE_KEYSTORE_NAME=teststore.ks
PRIVATE_KEYSTORE_PASS=123456789
EXPORTED_TEST_CERT=icedteatests.crt
TEST_CERT_ALIAS=icedteaweb
PUBLIC_KEYSTORE=~/.icedtea/security/trusted.certs
PUBLIC_KEYSTORE_PASS=changeit

I'm for keeping the password as it is, as it is not supposed to be changed, but just serve it 
purpose and be discarded.
>
>>> > +EXPORTED_CERT=icedteatests.crt
...
>>
>
> Awesome, thanks! After the above typos are fixed, go ahead and push to HEAD.

Thanx! pushed!
>
> Cheers,
> Danesh

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sgnw.diff
Type: text/x-patch
Size: 19473 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120418/114f0f32/sgnw.diff