[icedtea-web] Broken unit-tests

[Omair Majid]

On 04/23/2012 10:02 AM, Jiri Vanek wrote:
> I really do not see an connection between your changeset,  the failure
> and the fix you are suggesting.

Well, you are probably aware that 'make check' was working before that
changeset was pushed to the repo, right?  So Something in that changeset
is breaking the test runner. So there are two way to fix it:

1. Fix the test so it doesn't break the test runner.

2. Fix the test runner so it can handle this problematic test.

Your patch (from what I can tell) takes approach 2. The fix for
resources.jar takes approach 1 (and makes the test pass).

It would be good to have fixes for both 1 _and_ 2, so that no future
test can break the runner and the current test passes.

> If you have tried and it is working for you, I think you can push. As it
> can be useful to have resources.jar on classapth anyway.

I will push it in a bit.

> However - to fix this issue is better to  catch the proper exception in
> XmlOutputLIstener (which is probably consumed somehow and is causing the
> class lock itself in error state).

Oh, yes. The test runner needs to be fixed too. If you want to post an
isolated patch for just this, I will try and review it.

Cheers,
Omair