/hg/icedtea-web: Spelling fixes
Deepak Bhole
dbhole at redhat.com
Wed Apr 25 06:49:37 PDT 2012
* Thomas Meyer <thomas at m3y3r.de> [2012-04-25 04:04]:
>
> Zitat von Andrew Hughes <ahughes at redhat.com>:
> >----- Original Message -----
> >>diffstat:
> >>
> >> tests/netx/jnlp_testsengine/net/sourceforge/jnlp/ServerAccess.java |
> >> 106 ++++-----
> >> 1 files changed, 52 insertions(+), 54 deletions(-)
> >>
> >
> >This change needs a ChangeLog entry.
> >
> >Was it reviewed on the list?
>
> Yes, it was. Also somebody told me, that this kind of change doesn't
> need a review.
>
> >I don't see a review, but may have missed it.
> >Given it's just typo corrections, it can probably go in as trivial. But it
> >does need a ChangeLog.
>
> Okay, I didn't know that. So every change needs a Changelog entry,
> sound sensible :-) Should I add an entry for this change to the
> Changelog?
>
> PS: Why is the Changelog needed at all? The source code is under
> control of mercurial, so you have a changelog anyway?
>
Personally I find it useful if I have to go back and look at some
patchset to try and understand what was changed/why it was changed.
Cheers,
Deepak
>
More information about the distro-pkg-dev
mailing list