[rfc][icedtea-web] Fix for PR920, duplicate class loading when extending from outside jar

Jiri Vanek jvanek at redhat.com
Tue Aug 14 05:33:30 PDT 2012


On 07/10/2012 10:58 PM, Adam Domurad wrote:
> Also see [rfc][icedtea-web] Reproducer for PR920.
>
> Removes recursive/non-recursive call distinction in findClass for
> CodeBaseLoader, because, IMO it is not necessary when you set the parent
> classloader in the super() call. Any explicit calls to findClass will
> not recurse indefinitely.
>
> Causes PR920 reproducer that I posted to pass, with no new regressions.
>
> Ch-ch-changes:
> 2012-07-10  Adam Domurad<adomurad at redhat.com>
>
> 	Fixes PR920, duplicate loading of classes in certain cases
> 	* NEWS: Added entry: Fixes PR920
> 	* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Remove
> 	recursive/non-recursive distinction. Add parent JNLPClassLoader to
> 	parent chain. Calling findClass directly turns out to be enough to
> 	avoid recursive behaviour.

I have found nothing harmufull here, if you have spotted no regresiion, please push where you find appropriate. But please wait with push(es) until also reproducer is approved.


J.

ps: It is not a sin to ping forgotten patch;)



More information about the distro-pkg-dev mailing list