/hg/icedtea-web: Unit test for JCV.isMetaInfFile()

adomurad at icedtea.classpath.org adomurad at icedtea.classpath.org
Tue Aug 14 11:27:32 PDT 2012


changeset c0f74c4ad71b in /hg/icedtea-web
details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=c0f74c4ad71b
author: Adam Domurad <adomurad at redhat.com>
date: Tue Aug 14 14:22:22 2012 -0400

	Unit test for JCV.isMetaInfFile()


diffstat:

 ChangeLog                                                           |   8 ++++
 netx/net/sourceforge/jnlp/tools/JarCertVerifier.java                |   2 +-
 tests/netx/unit/net/sourceforge/jnlp/tools/JarCertVerifierTest.java |  17 ++++++++++
 3 files changed, 26 insertions(+), 1 deletions(-)

diffs (48 lines):

diff -r a86af88a8ecd -r c0f74c4ad71b ChangeLog
--- a/ChangeLog	Mon Aug 13 15:52:03 2012 +0200
+++ b/ChangeLog	Tue Aug 14 14:22:22 2012 -0400
@@ -1,3 +1,11 @@
+2012-08-14  Adam Domurad  <adomurad at redhat.com>
+
+	Unit test for method in JCV, isMetaInfFile()
+	* netx/net/sourceforge/jnlp/tools/JarCertVerifier.java: 
+	Made isMetaInfFile package-private for testing purposes.
+	* tests/netx/unit/net/sourceforge/jnlp/tools/JarCertVerifierTest.java:
+	New, tests isMetaInfFile
+
 2012-08-06  Jiri Vanek  <jvanek at redhat.com>
 
 	Added splashscreen implementation
diff -r a86af88a8ecd -r c0f74c4ad71b netx/net/sourceforge/jnlp/tools/JarCertVerifier.java
--- a/netx/net/sourceforge/jnlp/tools/JarCertVerifier.java	Mon Aug 13 15:52:03 2012 +0200
+++ b/netx/net/sourceforge/jnlp/tools/JarCertVerifier.java	Tue Aug 14 14:22:22 2012 -0400
@@ -456,7 +456,7 @@
      * . META-INF/*.DSA
      * . META-INF/*.RSA
      */
-    static private boolean isMetaInfFile(String name) {
+    static boolean isMetaInfFile(String name) {
         String ucName = name.toUpperCase();
         return ucName.startsWith(META_INF);
     }
diff -r a86af88a8ecd -r c0f74c4ad71b tests/netx/unit/net/sourceforge/jnlp/tools/JarCertVerifierTest.java
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/tests/netx/unit/net/sourceforge/jnlp/tools/JarCertVerifierTest.java	Tue Aug 14 14:22:22 2012 -0400
@@ -0,0 +1,17 @@
+package net.sourceforge.jnlp.tools;
+
+import static org.junit.Assert.*;
+
+import org.junit.Test;
+
+public class JarCertVerifierTest {
+
+    @Test
+    public void testIsMetaInfFile() {
+        final String METAINF ="META-INF";
+        assertFalse(JarCertVerifier.isMetaInfFile("some_dir/" + METAINF + "/filename"));
+        assertFalse(JarCertVerifier.isMetaInfFile(METAINF + "filename"));
+        assertTrue(JarCertVerifier.isMetaInfFile(METAINF + "/filename"));
+    }
+
+}



More information about the distro-pkg-dev mailing list