[rfc][icedtea-web] fixing failing unittests CodeBaseClassLoaderTest.java

Deepak Bhole dbhole at redhat.com
Fri Aug 24 12:56:17 PDT 2012


Hi Jiri,

Sorry for the late review; too much other stuff in the way :(

* Jiri Vanek <jvanek at redhat.com> [2012-08-10 05:24]:
> On 08/09/2012 03:29 PM, Deepak Bhole wrote:
> >* Jiri Vanek <jvanek at redhat.com> [2012-08-09 07:30]:

...
...

> +
> +        assertTrue(timeOnSecondTry < (timeOnFirstTry / 10));

These checks for 1/10th of the time seem arbitrary. Couldn't it lead to
intermittent failures?

...
...

...

>  
>          JNLPClassLoader parent = new JNLPClassLoader(dummyJnlpFile, null);
> -        CodeBaseClassLoader classLoader = new CodeBaseClassLoader(new URL[] { JAR_URL, CODEBASE_URL }, parent);
> +        CodeBaseClassLoader classLoader = new CodeBaseClassLoader(new URL[]{JAR_URL, CODEBASE_URL}, parent);
>  

Minor nitpick but the spaces from before should be there :)

Rest looks good -- thanks!

Cheers,
Deepak



More information about the distro-pkg-dev mailing list