[icedtea-web] PR1145: IcedTea-Web can cause ClassCircularityError

[Omair Majid]

On 08/28/2012 09:36 AM, Adam Domurad wrote:
> Do you also want to incorporate your first idea into HEAD ? (I
> admittedly skimmed the patch but you said it brought it closer to
> classloader specs). 

I looked at the ClassLoader spec again, found a subtle difference
between what it describes and what the implementation in icedtea-web
does. icedtea-web uses a peer-loader model to load classes using other
class loaders - we use findLoadedClassesAll to query peers, rather than
using findLoadedClass to query just the current classloader in
loadClass. Changing this might break icedtea-web.

Renaming/refactoring the findClass and loadClass methods to ensure they
split responsibility along the lines of what javadocs describe is
probably a good thing to do anyway. But I am not going to be doing that
right now.

Cheers,
Omair