/hg/icedtea-web: Added browser softkiller and related Makefile.

[Pavel Tisnovsky]

Hi Saad,

thank you very much for detecting this issue. I'll fix ASAP.

Cheers,
Pavel

----- Saad Mohammad <smohammad at redhat.com> wrote:
> Hi Pavel,
> 
> Just one minor issue with this patch, it's breaking 'make clean'. The fix is
> very simple, so feel free to directly push.
> 
> Comment below.
> 
> [..snip..]
> > diff -r 172a5691e70d -r eedc15145aa6 Makefile.am
> > --- a/Makefile.am	Fri Nov 30 13:08:45 2012 -0500
> > +++ b/Makefile.am	Mon Dec 03 14:43:18 2012 +0100
> > @@ -39,6 +39,7 @@
> >  export TEST_CERT_ALIAS=icedteaweb
> >  export PUBLIC_KEYSTORE=${HOME}/.icedtea/security/trusted.certs
> >  export PUBLIC_KEYSTORE_PASS=changeit
> > +export SOFTKILLER=softkiller
> >  
> >  export JUNIT_RUNNER_JAR=$(abs_top_builddir)/junit-runner.jar
> >  export UNIT_CLASS_NAMES = $(abs_top_builddir)/unit_class_names
> > @@ -808,9 +809,14 @@
> >  	done ; \
> >  	echo $$class_names > $(REPRODUCERS_CLASS_NAMES)
> >  
> > +$(TESTS_DIR)/$(SOFTKILLER):
> > +	cd  $(TESTS_SRCDIR)/$(SOFTKILLER); \
> > +	$(MAKE) ; \
> > +	mv $(SOFTKILLER) $(TESTS_DIR)/
> > +
> >  stamps/run-netx-dist-tests.stamp: stamps/netx-dist.stamp extra-lib/about.jar stamps/plugin.stamp launcher.build/$(javaws) \
> >   javaws.desktop stamps/docs.stamp launcher.build/$(itweb_settings) itweb-settings.desktop \
> > - stamps/netx.stamp stamps/junit-jnlp-dist-dirs stamps/netx-dist-tests-import-cert-to-public \
> > + stamps/netx.stamp stamps/junit-jnlp-dist-dirs stamps/netx-dist-tests-import-cert-to-public $(TESTS_DIR)/softkiller \
> >   stamps/test-extensions-compile.stamp stamps/compile-reproducers-testcases.stamp $(JUNIT_RUNNER_JAR) stamps/copy-reproducers-resources.stamp\
> >   $(TESTS_DIR)/$(REPORT_STYLES_DIRNAME) $(REPRODUCERS_CLASS_NAMES) stamps/process-custom-reproducers.stamp
> >  	cd $(TEST_EXTENSIONS_DIR) ; \
> > @@ -1191,7 +1197,10 @@
> >  	rm -rf  $(TESTS_DIR)/$(REPORT_STYLES_DIRNAME)/
> >  	rm -f  $(TESTS_DIR)/*.html
> >  
> > -clean-netx-dist-tests: clean_tests_reports netx-dist-tests-remove-cert-from-public clean-custom-reproducers
> > +clean-$(SOFTKILLER):
> > +	rm  $(TESTS_DIR)/softkiller
> 
> Please add the '-f' option so we can avoid any errors if the file does not exist.
> 
> [..snip..]
> 
> Thanks! And great patch by the way!
> 
> -- 
> Cheers,
> Saad Mohammad