[RFC][icedtea-web]: Small fix for PR1189 w/ reproducer

[Adam Domurad]

On 12/10/2012 03:28 PM, Saad Mohammad wrote:
> Hi Adam,
>
> Thanks for taking a look over the patches! Unit test is now attached with few
> comments below.
>
> CHANGELOG - Unittest
> ========================================================================
> 2012-12-10  Saad Mohammad  <smohammad at redhat.com>
>
> 	Add unit tests for PR1189.
> 	* tests/netx/unit/net/sourceforge/jnlp/PluginParametersTest.java:
> 	(testConstructorWithNoCodeAndObjectParam): Initialize PluginParameters
> 	without code/object parameters.
> 	(testConstructorWithOnlyJnlpHrefParam): Initialize PluginParameters with
> 	jnlp_href but no code/object parameters.
> ========================================================================
>
> On 12/10/2012 02:13 PM, Adam Domurad wrote:
>
> [...snip...]
>
>>> diff --git a/netx/net/sourceforge/jnlp/PluginParameters.java
>>> b/netx/net/sourceforge/jnlp/PluginParameters.java
>>> --- a/netx/net/sourceforge/jnlp/PluginParameters.java
>>> +++ b/netx/net/sourceforge/jnlp/PluginParameters.java
>>> @@ -54,7 +54,8 @@
>>>            this.parameters = createParameterTable(params);
>>>              if (this.parameters.get("code") == null
>>> -                && this.parameters.get("object") == null) {
>>> +                && this.parameters.get("object") == null
>>> +                && this.parameters.get("jnlp_href") == null) {
>>>                throw new PluginParameterException(R("BNoCodeOrObjectApplet"));
>>>            }
>>>        }
>> Is this all that is currently needed, ie are the main-class-name related changes
>> from the previous patch already added ?
> The main-class name related changes from previous patch have been already added
> through PR1166 fix. Therefore this is the only change needed for the fix.
>
> <http://icedtea.classpath.org/hg/icedtea-web/rev/c3d0eaf5460c>
>
>> A comment here about why jnlp_href causes the exception not to occur may be good.
>>
> Will do!
>
>> Can you take a look at the unit test (PluginParametersTest) and add something
>> that executes this code-path (ie has a jnlp_href but not the other two) ?
>>
> See attached files.
>
>> Otherwise good.
>>
>
> [...snip...]
>
> UnitTest + Reproducer + Fix (with added comment) okay to push to HEAD?
>

Approved, go ahead.

Also, I didn't know about the 'expected' exception specifier for @Test, 
quite neat.

Thanks,
-Adam