[rfc][icedtea-web] additions to test-extensions needed for the new AWTFramework

[Jiri Vanek]

On 12/13/2012 11:03 AM, Jana Fabrikova wrote:
> 2012-12-13  Jana Fabrikova  <jfabriko at redhat.com>
>
>      * /tests/test-extensions/net/sourceforge/jnlp/ServerAccess.java:
>      Added several new versions of method executeBrowser with lists
>      of ContentReaderListeners as arguments.
>
>      * /tests/test-extensions/net/sourceforge/jnlp/ProcessWrapper.java:
>      Added new versions of the constructor and methods for adding
>      ContentReaderListeners using List<ContentReaderListener>
>      instead of one ContentReaderListener.
>      Added a new version of constructor with less arguments (used
>      in case when several arguments would be passed as null, thus
>      causing ambiguity).
>
>      * /tests/reproducers/simple/SingeInstanceServiceTest/testcases/SingleInstanceTest.java:
>      Modified the call of executeBrowser method with null arguments
>      into a call of new method without the null arguments
>      (getting rid of an ambiguous call).
>
>
> I would like to ask for review of the attached patch,
> thank you,
> Jana

It looks much bettter. You forgot to fix the changelog (parentheses around affected and new methods. 
Listed with some luck all of them)
Still nasty comment:  //current browser may be
                                                             // null, but it does not
                                                             // matter

Should be on one line.

Although there are still some duplications I'm ok with them and after above changes ok for head.

J.