RFR: Fix zero fail to build in icedtea7-head...

[Roman Kennke]

Am Dienstag, den 18.12.2012, 20:18 -0500 schrieb Chris Phillips:
> Attached patch is a backport of Roman's jdk8 fixes to Icedtea7-head.
> 
> Please review.

It looks good to me. Some little comments:

--- old/make/Makefile	2012-12-13 09:16:51.027908161 -0500
+++ new/make/Makefile	2012-12-13 09:16:50.887903544 -0500
@@ -402,14 +402,30 @@
     ifeq ($(JVM_VARIANT_ZEROSHARK), true)
         $(EXPORT_JRE_LIB_ARCH_DIR)/%.$(LIBRARY_SUFFIX):
$(SHARK_DIR)/%.$(LIBRARY_SUFFIX)
 		$(install-file)
+        $(EXPORT_JRE_LIB_ARCH_DIR)/%.debuginfo):

Here's one one closing parenthesis too much    ^ It means builds with
expanded debuginfo will not work. This was my mistake, and it even
slipped through to upstream jdk8. (A fix is on its way...)


--- old/src/cpu/zero/vm/relocInfo_zero.cpp	2012-12-13 09:16:54.884035322
-0500
+++ new/src/cpu/zero/vm/relocInfo_zero.cpp	2012-12-13 09:16:54.775031727
-0500
@@ -77,3 +77,7 @@
                                                        CodeBuffer*
dst) {
   ShouldNotCallThis();
 }
+//
+//void metadata_Relocation::pd_fix_value(address x) {
+//  ShouldNotCallThis();
+//}

There's no reason to add commented-out code. (Was that in my original
patch? I hope not..)


Other than that, it looks good to me!

Cheers,
Roman