[rfc][icedtea-web] Minor addition to C++ testing; cleanup
Pavel Tisnovsky
ptisnovs at redhat.com
Fri Dec 21 09:04:17 PST 2012
Hi Adam,
this change looks ok. As far as I know you also need to
check if TMPDIR env. variable points to proper directory in case
this variable exists instead of use /tmp as the first
fallback (it should be second fallback ;)
Changelog typo:
s/explict/explicit
Cheers,
Pavel
----- Adam Domurad <adomurad at redhat.com> wrote:
> 2012-12-XX Adam Domurad <adomurad at redhat.com>
>
> * plugin/icedteanp/IcedTeaNPPlugin.cc: Remove need for 'goto' in
> (NP_Initialize).
> Expose some previously static variables/functions for unit testing
> purposes. Reduce need for explict allocations for strings
> 'data_directory' and 'appletviewer_executable'.
> * tests/cpp-unit-tests/IcedTeaNPPluginTest.cc:
> Add some basic tests for functions in IcedTeaNPPlugin.cc.
>
> The biggest change out of here I want is that NP_Initialize has
> considerably less string-fiddling/goto noise.
>
> Happy hacking,
> -Adam
More information about the distro-pkg-dev
mailing list