[rfc][icedtea-web] fixinf of desktop icon behaviour

[Jiri Vanek]

On 12/27/2012 07:04 PM, Omair Majid wrote:
> On 12/21/2012 11:38 AM, Adam Domurad wrote:
>> On 12/21/2012 11:05 AM, Jiri Vanek wrote:
>>> Hi! This is fix for
>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=725 - JNLP
>>> applications will prompt for creating desktop shortcuts every time
>>> they are run
>>>
>>> When I have seen Omairs original patch it was too much complicated, So
>>> I want at least to try this one.
>>
>> Do you know why Omair used explicit locking? I couldn't quite figure it out
>>
>
> My first patch kept a record of all desktop entries that icedtea-web
> created in a file. This meant that if a user deleted the desktop icon,
> icedtea-web wouldn't prompt for the creation of that icon again.
>

I was thinking about it in vice-versa. If he had  already created icon, and then he delted it. And some time later he launch application again, I would expect he would like to be asked again.
However, when he will refuse to create an desktop icon then he should not be asked again.. that is *probably* true, but I'm not so sure... And to achieve this something like your previous approach is needed.

So what do you think about combination of my and yours approach?


> It was important to lock that record file to prevent multiple
> icedtea-web processes from editing it simultaneously.
>
> Cheers,
> Omair