[RFC][icedtea-web] Use description param when creating a LaunchException

Deepak Bhole dbhole at redhat.com
Wed Feb 1 11:30:43 PST 2012


* Danesh Dadachanji <ddadacha at redhat.com> [2012-02-01 14:28]:
> 
> 
> On 01/02/12 03:11 AM, Jiri Vanek wrote:
> >On 01/31/2012 09:59 PM, Danesh Dadachanji wrote:
> >>Hi,
> >>
> >>I stumbled onto this while throwing an exception in my patch for
> >>single instance with jnlp_href. We never output the description
> >>parameter passed into the constructor of LaunchException. The message
> >>passed into the super call doesn't include it so the user will never
> >>see it.
> >>
> >>I see no harm in adding the details to the message outputted when an
> >>exception is thrown. Currently, all the values passed as description
> >>are either direct empty strings or localized keys that have no text.
> >>Can we put it to some use? The patch mentioned above does so and
> >>perhaps this will encourage others to do so! =)
> >>
> >>ChangeLog:
> >>+2012-01-31 Danesh Dadachanji <ddadacha at redhat.com>
> >>+
> >>+ * netx/net/sourceforge/jnlp/LaunchException.java: Add description
> >>+ parameter to the message the exception stores.
> >>+
> >>
> >>
> >>Thoughts? Okay for HEAD?
> >>
> >>Cheers,
> >>Danesh
> >
> >Nice. Approved. I think it should go to Head and 1.2.
> >
> 
> Thanks for the review! I've held off pushing to 1.2 for now though.
> 

This should be OK for 1.2 as well. Please push there too.

Cheers,
Deepak



More information about the distro-pkg-dev mailing list