Broken applet test

Danesh Dadachanji ddadacha at redhat.com
Mon Feb 6 08:47:34 PST 2012


Hi Jiri,

My apologies for this regression! =( Commenting below.

On 05/02/12 08:01 AM, Jiri Vanek wrote:
> This commit -
> http://icedtea.classpath.org/hg/icedtea-web/rev/221174bcd4ec ,
> especially this hunk:

[snip]

> have broken applet test. I have verified manually. With this patch
> applet lunched via jnlp (but I have not tested embedded applets - they
> can be affected to!) is causing null pointer exception (only in verbose
> mode, without it just died)
> When the "bad hunk" is reverted, applet works as expected.

I noticed this problem before when testing some other jnlp_href stuff. 
The exception I found was in AppletEnvironment, I assume this is the 
same one that you noticed? I missed setting up AppletEnvironment 
properly after AppletInstance is setup. I thought any reference to the 
applet var would be from AppletInstance, I didn't realize 
AppletEnvironment had its own reference too.

I'm testing some code right now that assigns AppletEnvironment.applet 
after AppletInstance is initialized, I'll post a RFC by the end of the 
day. I want to make sure I didn't miss anything this time around!

Regards,
Danesh



More information about the distro-pkg-dev mailing list