[RFC][icedtea-web] Fix regression in broken AppletTest (Was Re: Broken applet test)

Jiri Vanek jvanek at redhat.com
Mon Feb 13 06:01:47 PST 2012


On 02/10/2012 11:20 PM, Danesh Dadachanji wrote:
> On 08/02/12 09:59 AM, Jiri Vanek wrote:
>>
>> Hi Danesh, attached patch adds netx jar on reproducers classpath. Can
>> you try it on your test and if works, you can commit it together with
>> your test.
>> Every test i so welcomed!
>>
>> J.
>
> Hey Jiri,
>
> The patch didn't work. =( What's the default classpath when running this part of the Makefile? If this doesn't include the right jar, then it'll crash. I ran it with
Default classpath s just the one behind -cp.
>
> - $(BOOT_DIR)/bin/javac -cp $(NETX_DIR)/lib/classes.jar -d "$(JNLP_TESTS_DIR)/$$dir/" $$srcFiles ; \
> + $(BOOT_DIR)/bin/javac -cp $(NETX_DIR)/lib/classes.jar:$(NETX_DIR)/javax/jnlp/ -d "$(JNLP_TESTS_DIR)/$$dir/" $$srcFiles ; \
>
>
>
> but that said javax.jnlp.BasicService is a bad class :P Do you know of any other location where javax stuff is stored?
>

It is wired! Can you play arround a bit? Also - I did not added jar, but directory with classes. And It looks suspicious to me:-/ ..It looks like I have added some nonsense at all..:-/....Still classes.jar should have everything what is needed! :-/  In case you do not want to play with it you must give me  some time.  But I suggest to add this classpath entry rather then use reflection.
> A quick question, I am running 'make run-netx-dist-tests', is this correct? When this is run, all is run too, right? (make all equivalent).
YES!
Sometimes it looks like there is something bad and is necessary run make install before tests themselves. (do not forget to add --prefix during configure! See wiki)
But - i have suspicion  you have installed rpm with icedtea-web  - didn't you?  again see wiki - http://icedtea.classpath.org/wiki/IcedTea-Web#Building_IcedTea-Web  especially warning.
>
> Also should we move this to distro?
Sure - done.

Thanx for looknig to this, J.
>
> Cheers,
> Danesh




More information about the distro-pkg-dev mailing list