[RFC][icedtea-web] Path to NEW_LINE_IFS is incorrect

Danesh Dadachanji ddadacha at redhat.com
Mon Feb 13 08:50:39 PST 2012


On 11/02/12 04:14 AM, Jiri Vanek wrote:
> On 02/10/2012 11:10 PM, Danesh Dadachanji wrote:
>> Hi,
>>
>> The var abs_top_builddir is used as the path to NEW_LINE_IFS when it
>> should be abs_top_srcdir. When building outside of src dir (e.g. in
>> icedtea-web/build with ../configure), this will fail when running say
>> 'make run-netx-dist-tests'. It mustn't have been caught yet because
>> people are probably building in the src dir directly when testing..
>>
>> ChangeLog:
>> +2012-02-10 Danesh Dadachanji <ddadacha at redhat.com>
>> +
>> + Fix path to NEW_LINE_IFS for when one builds outside of src directory.
>> + * Makefile.am: Use top src directory instead of top build directory
>> + for NEW_LINE_IFS
>> +
>>
>> Is the attached patch okay for HEAD and 1.2?
>>
>
> Approved. TY for correction.

Thanks for the review! Pushed here:

http://icedtea.classpath.org/hg/release/icedtea-web-1.2/rev/c959afd1eba7
http://icedtea.classpath.org/hg/icedtea-web/rev/89eb20442421

Cheers,
Danesh



More information about the distro-pkg-dev mailing list