[RFC][icedtea-web] Test for regression of ServiceManager not setup correctly

[Omair Majid]

On 02/17/2012 05:34 PM, Danesh Dadachanji wrote:
> Hi,
> 
> Here's a test that checks whether or not ServiceManager is setup
> correctly by the time an applet constructor is called. The constructor
> uses BasicService and will throw a NPE if it is not setup.
> 

Would it be possible to extend this test to check that services are
available in init(), start(), stop() and destroy() as well?

There also seem to be some spacing/indentation issues in the patch.

> The test is for checking regression against this changeset:
> http://icedtea.classpath.org/hg/icedtea-web/rev/221174bcd4ec
> 
> Thank you very much to Jiri for helping me get this through the door!
> 
> +2012-02-17  Danesh Dadachanji  <ddadacha at redhat.com>
> +
> +    Adding test for regression of JNLP API accessibility in constructor
> +    methods of applets.
> +    * Makefile.am: Added classes.jar to classpath when compiling
> jnlp_tests.
> +    * tests/jnlp_tests/simple/CheckServices/: Tests ServiceManager is
> setup
> +    correctly when called from applet constructors.

Please list all the files added or changed.

In general, am not sure how good these applet tests might be. We know
that applets run under javaws use different code paths from applets run
under a browser. Still it's better to have a few tests than none.

Cheers,
Omair