RFC: fix problems in jforex charts

Andrew Haley aph at redhat.com
Tue Feb 28 01:21:37 PST 2012


On 02/27/2012 09:02 PM, Omair Majid wrote:
> diff --git a/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java b/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java
> --- a/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java
> +++ b/plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java
> @@ -50,7 +50,7 @@
>          String[] args = message.split(" ");
>          // FIXME: Is it even possible to distinguish between null and void
>          // here?
> -        if (args[3] != "null" && args[3] != "void")
> +        if (args.length > 3 && args[3] != "null" && args[3] != "void")
>              object = AppletSecurityContextManager.getSecurityContext(0).getObject(Integer.parseInt(args[3]));
>          setDone(true);
>      }

This is rather horrible.

It would be much nicer to write a method that trims garbage args
and then check the length of the trimmed arg list.

Andrew.



More information about the distro-pkg-dev mailing list