[icedtea-web] RFC: Patch to check the manifest file for main class

Deepak Bhole dbhole at redhat.com
Tue Feb 28 08:39:27 PST 2012


* Omair Majid <omajid at redhat.com> [2012-02-28 11:34]:
> On 02/28/2012 11:04 AM, Deepak Bhole wrote:
> > 
> > New patch attached.
> > 
> 
> Looks good to me. If I may make one more request: can we add a
> reproducer to icedtea-web itself? Not necessarily as part of this patch,
> though.
> 

I just committed the patch, but sure, I will look into it after 1.2 is
out (I'd do it now but I need to really study how the new testing
infrastructure works :/).

We also need to fix code in Launcher to look in more than just Main jar
manifest -- however that is out of the scope for this patch. This patch
was to fix a regression in 1.2 vs 1.1 which is now fixed. The bug in
Launcher has always existed.

Cheers,
Deepak



More information about the distro-pkg-dev mailing list